Move Prism dependency to gemspec file from Gemfile #288
Conversation
* Gemfile, typeprof.gemspec: Using TypeProf as a library does not resolve Gemfile dependencies. In particular, TypeProf uses the start_code_units_column method introduced in Prism version 0.23.0, so it must be at least that version or later.
|
@gemmaro My guess is that this is intentionally not being loaded to prevent the typeprof version from being included in Gemfile.lock. |
|
@sinsoku I understand your point. Since TypeProf is a gem used as an application rather than a library, it makes sense to keep things as they are. I'll go ahead and close this then. |
|
@gemmaro I think adding prism to the gemspec is a good change. What I meant to suggest was:
Having the dependency in both places ensures it works properly for both gem users and development environments. Note: The prism version requirement was updated to ">= 1.4.0" in #312. Would you like to reopen the PR with just the gemspec change? |
|
Thank you for the clarification. Your suggested modification sounds good to me. However, before proceeding, I’d like to briefly ask the repository members about how they prefer to manage dependencies and respect their intention. I’ll mention @mame to confirm -- sorry in advance for my noise -- whether the decision not to load the gemspec from the Also, thank you for sharing that the version requirement for Prism was updated. I appreciate it. |
2 participants
Using TypeProf as a library does not resolve
Gemfiledependencies. In particular, TypeProf uses thestart_code_units_columnmethod introduced in Prism version 0.23.0, so it must be at least that version or later.